Keyboard fixes #11586
Merged
Keyboard fixes #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
keyboard-fixes
branch
from
7baa270 to
2490c87
Compare
manucorporat
force-pushed
the
keyboard-fixes
branch
from
0613f8e to
082d234
Compare
manucorporat
commented
May 19, 2017
src/components/datetime/datetime.ts
Outdated
| @@ -259,6 +259,7 @@ import { dateValueRange, renderDateTime, renderTextFormat, convertDataToISO, con | |||
| 'ion-button="item-cover" ' + | |||
| '[attr.aria-labelledby]="_labelId" ' + | |||
| '[attr.aria-disabled]="_disabled" ' + | |||
| '(click)="_click($event)" ' + | |||
src/components/input/input.scss
Outdated
| @@ -119,7 +87,6 @@ input.text-input:-webkit-autofill { | |||
| pointer-events: auto; | |||
| } | |||
|
|
|||
|
|
|||
src/components/item/item-sliding.ts
Outdated
| @@ -346,6 +346,7 @@ export class ItemSliding { | |||
| } | |||
| if (openAmount === 0) { | |||
| this._tmr = platform.timeout(() => { | |||
| // change in the code | |||
src/components/radio/radio-button.ts
Outdated
| @@ -134,6 +134,8 @@ export class RadioButton extends Ion implements IonicTapInput, OnDestroy, OnInit | |||
| } | |||
| } | |||
|
|
|||
| initFocus() { } | |||
| @@ -206,10 +206,6 @@ export class Select extends BaseInput<any> implements OnDestroy { | |||
|
|
|||
| @HostListener('click', ['$event']) | |||
| _click(ev: UIEvent) { | |||
| if (ev.detail === 0) { | |||
There was a problem hiding this comment.
review, ask @adamdbradley
src/util/base-input.ts
Outdated
| /** | ||
| * @hidden | ||
| */ | ||
| focusNext() { |
There was a problem hiding this comment.
where is focusNext() used? need to review it
how does it interact between input, toggle, checkbox (look at items/inputs)
src/util/form.ts
Outdated
| const inputs = this._inputs; | ||
| let index = this._inputs.indexOf(currentInput) + 1; | ||
| if (index > 0 && index < inputs.length) { | ||
| let nextInput = inputs[index]; |
There was a problem hiding this comment.
add unit tests! make sure I didn't break anything
| @@ -68,6 +68,20 @@ export class ScrollView { | |||
| this._eventsEnabled = true; | |||
| } | |||
|
|
|||
| setScrolling(isScrolling: boolean, ev: ScrollEvent) { | |||
There was a problem hiding this comment.
review with @adamdbradley (explain use case)
add support for JS-scrolling? maybe not needed
add new unit tests
src/components/input/input.ts
Outdated
| '<textarea #textInput *ngIf="_isTextarea" class="text-input" ' + | ||
| '[(ngModel)]="value" ' + | ||
| '(blur)="onBlur()" ' + | ||
| '(focus)="onFocus()" ' + |
There was a problem hiding this comment.
we could use non-zoned focusin/focusout programatically!!
| this._usePadding = config.getBoolean('scrollPadding', this._useAssist); | ||
|
|
||
| if (elementRef.nativeElement.tagName === 'ION-TEXTAREA') { | ||
| this._type = TEXTAREA; |
There was a problem hiding this comment.
make sure type has the correct value.
add unit test
manucorporat
commented
May 19, 2017
src/components/datetime/datetime.ts
Outdated
| _click(ev: UIEvent) { | ||
| // do not continue if the click event came from a form submit |
There was a problem hiding this comment.
review, ask @adamdbradley
manucorporat
commented
May 21, 2017
src/util/base-input.ts
Outdated
| this._isFocus = true; | ||
| console.debug('BaseInput: focused:', this); | ||
| this._form && this._form.setAsFocused(this); | ||
| this._inputFocusChanged(true); |
There was a problem hiding this comment.
we might not need _inputFocusChanged
manucorporat
force-pushed
the
keyboard-fixes
branch
from
d22d927 to
257bbb7
Compare
|
Hi @manucorporat, do you think this PR can fix #11745 ? |
manucorporat
force-pushed
the
keyboard-fixes
branch
6 times, most recently
from
f844f6c to
078dc62
Compare
manucorporat
force-pushed
the
keyboard-fixes
branch
7 times, most recently
from
7928f65 to
574ee31
Compare
fixes ionic-team#9699 fixes ionic-team#11484 fixes ionic-team#11389 fixes ionic-team#11325 fixes ionic-team#11291 fixes ionic-team#10828 fixes ionic-team#11291 fixes ionic-team#10393 fixes ionic-team#10257 fixes ionic-team#9434 fixes ionic-team#8933 fixes ionic-team#7178 fixes ionic-team#7047 fixes ionic-team#10552 fixes ionic-team#10393 fixes ionic-team#10183 fixes ionic-team#10187 fixes ionic-team#10852 fixes ionic-team#11578
manucorporat
force-pushed
the
keyboard-fixes
branch
from
574ee31 to
c10f72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
fixes #7047
fixes #9699
fixes #11566
fixes #11484
fixes #11389
fixes #11325
fixes #11291
fixes #11251 ?
fixes #10552
fixes #10393
fixes #10183
fixes #10187